On 25/2/24 18:08, BALATON Zoltan wrote:
On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote:
On 23/2/24 15:26, BALATON Zoltan wrote:
Remove last two includes of hw/ide/intarnal.h outside of hw/ide and
replace them with newly added public header to allow moving internal.h
into hw/ide to really stop exposing it.

Fixes: a11f439a0e (hw/ide: Stop exposing internal.h to non-IDE files)
Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu>
---
  hw/arm/sbsa-ref.c                 | 2 +-
  {include/hw => hw}/ide/internal.h | 0
  include/hw/misc/macio/macio.h     | 2 +-
  3 files changed, 2 insertions(+), 2 deletions(-)
  rename {include/hw => hw}/ide/internal.h (100%)

diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index 5d3a574664..f027622a75 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -36,7 +36,7 @@
  #include "hw/arm/smmuv3.h"
  #include "hw/block/flash.h"
  #include "hw/boards.h"
-#include "hw/ide/internal.h"
+#include "hw/ide/ide-bus.h"
  #include "hw/ide/ahci_internal.h"

Unrelated, but what about this one ^?

The ahci_internal.h is in hw/ide not in include/hw/ide so how does that even work? I don't care about AHCI so not interested to anything about that personally.

No worries, done:
https://lore.kernel.org/qemu-devel/20240225171637.4709-2-phi...@linaro.org/


Regards,
BALATON Zoltan


Reply via email to