On Mon, Feb 12, 2024 at 05:04:28PM +0100, Cédric Le Goater wrote: > and then, in background we have open questions regarding : > > * the QEMUfile implementation and its QIOChannel usage for migration > streams > * qemu_file_set_error* vs. migrate_set_error. It is confusing, at least > for me. Do we have some documentation on best practices ?
Right it is confusing.. It can all boil down to the acient qemufile api that Fabiano also mentioned in the other reply. IMHO ideally iochannel errors should be reported through the stack (rather than kept within the object) from the channel's API and stored with migrate_set_error() if necessary, and the channel itself may not need to maintain its own errors. Right now it's needed because many qemufile APIs do not return errors. Thanks, -- Peter Xu
