On Wed, Feb 21, 2024 at 10:15:55AM -0800, nifan....@gmail.com wrote: > From: Fan Ni <fan...@samsung.com> > > Per cxl spec r3.1, add dynamic capacity region representative based on > Table 8-165 and extend the cxl type3 device definition to include dc region > information. Also, based on info in 8.2.9.9.9.1, add 'Get Dynamic Capacity > Configuration' mailbox support. > > Note: decode_len of a dc region is aligned to 256*MiB, divided by > 256 * MiB before returned to the host for "Get Dynamic Capacity Configuration" > mailbox command. > > Signed-off-by: Fan Ni <fan...@samsung.com> > --- > hw/cxl/cxl-mailbox-utils.c | 110 ++++++++++++++++++++++++++++++++++++ > include/hw/cxl/cxl_device.h | 16 ++++++ > 2 files changed, 126 insertions(+) > > diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c > index ba1d9901df..88e3b733e3 100644 > --- a/hw/cxl/cxl-mailbox-utils.c > +++ b/hw/cxl/cxl-mailbox-utils.c > @@ -22,6 +22,7 @@ >
[snip] > +#ifdef CXL_SPEC_AFTER_R30 > + /*FIXME: need to set valid values in the future*/ > + stq_le_p(&extra_out->num_extents_supported, 0); > + stq_le_p(&extra_out->num_extents_available, 0); > + stq_le_p(&extra_out->num_tags_supported, 0); > + stq_le_p(&extra_out->num_tags_available, 0); Hello, It's a trivial comment and doesn't have any impact yet, but shouldn't it be stl_le_p()? Thanks, Wonjae
