On Fri Jan 19, 2024 at 8:09 AM AEST, Richard Henderson wrote: > On 1/19/24 02:25, Nicholas Piggin wrote: > > +/* attn enable check > > */ > > +static inline int check_attn_none(CPUPPCState *env) > > Don't mark inline ... > > > @@ -2150,6 +2170,7 @@ POWERPC_FAMILY(405)(ObjectClass *oc, void *data) > > dc->desc = "PowerPC 405"; > > pcc->init_proc = init_proc_405; > > pcc->check_pow = check_pow_nocheck; > > + pcc->check_attn = check_attn_none; > > ... since it is never called directly.
True, I mindlessly followed check_pow_none(). Maybe all those helpers could be uninlined and moved into cpu_init.c. Thanks, Nick
