* Philippe Mathieu-Daudé (phi...@linaro.org) wrote:
> This command has been deprecated before the 8.1 release,
> in commit e9ccfdd91d ("hmp: Add 'one-insn-per-tb' command
> equivalent to 'singlestep'"). Time to drop it.
>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Reviewed-by: Dr. David Alan Gilbert <d...@treblig.org>
> ---
> docs/about/deprecated.rst | 9 ---------
> docs/about/removed-features.rst | 6 ++++++
> tests/qtest/test-hmp.c | 1 -
> hmp-commands.hx | 13 -------------
> 4 files changed, 6 insertions(+), 23 deletions(-)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 25527da423..316a26a82c 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -167,15 +167,6 @@ points was removed in 7.0. However QMP still exposed the
> vcpu
> parameter. This argument has now been deprecated and the remaining
> remaining trace points that used it are selected just by name.
>
> -Human Monitor Protocol (HMP) commands
> --------------------------------------
> -
> -``singlestep`` (since 8.1)
> -''''''''''''''''''''''''''
> -
> -The ``singlestep`` command has been replaced by the ``one-insn-per-tb``
> -command, which has the same behaviour but a less misleading name.
> -
> Host Architectures
> ------------------
>
> diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst
> index a8546f4787..855d788259 100644
> --- a/docs/about/removed-features.rst
> +++ b/docs/about/removed-features.rst
> @@ -635,6 +635,12 @@ Use ``migrate-set-parameters`` instead.
>
> This command didn't produce any output already. Removed with no replacement.
>
> +``singlestep`` (removed in 9.0)
> +'''''''''''''''''''''''''''''''
> +
> +The ``singlestep`` command has been replaced by the ``one-insn-per-tb``
> +command, which has the same behaviour but a less misleading name.
> +
> Guest Emulator ISAs
> -------------------
>
> diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c
> index fc9125f8bb..1b2e07522f 100644
> --- a/tests/qtest/test-hmp.c
> +++ b/tests/qtest/test-hmp.c
> @@ -64,7 +64,6 @@ static const char *hmp_cmds[] = {
> "qom-get /machine initrd",
> "screendump /dev/null",
> "sendkey x",
> - "singlestep on",
> "wavcapture /dev/null",
> "stopcapture 0",
> "sum 0 512",
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 765349ed14..fc5f5c57ad 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -398,19 +398,6 @@ SRST
> If called with option off, the emulation returns to normal mode.
> ERST
>
> - {
> - .name = "singlestep",
> - .args_type = "option:s?",
> - .params = "[on|off]",
> - .help = "deprecated synonym for one-insn-per-tb",
> - .cmd = hmp_one_insn_per_tb,
> - },
> -
> -SRST
> -``singlestep [off]``
> - This is a deprecated synonym for the one-insn-per-tb command.
> -ERST
> -
> {
> .name = "stop|s",
> .args_type = "",
> --
> 2.41.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
