On Tue, Nov 28, 2023 at 09:36:47AM -0500, Cole Robinson wrote: > binutils 2.39 shows some warnings when building pvh.img > > /usr/bin/ld: warning: pvh.o: missing .note.GNU-stack section implies > executable stack > /usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in a > future version of the linker > /usr/bin/ld: warning: pvh.img has a LOAD segment with RWX permissions > > The latter of which is fatal on Fedora rawhide for some reason. > > Add linker options to suppress the errors
This makes it silent, but I guess someone needs to confirm that this option ROM code genuinely does NOT need to have executable stack, otherwise the future change that is being warned about could impact it ? > > Signed-off-by: Cole Robinson <crobi...@redhat.com> > --- > pc-bios/optionrom/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile > index 30d07026c7..f54ed39b54 100644 > --- a/pc-bios/optionrom/Makefile > +++ b/pc-bios/optionrom/Makefile > @@ -36,7 +36,7 @@ config-cc.mak: Makefile > $(call cc-option,-Wno-array-bounds)) 3> config-cc.mak > -include config-cc.mak > > -override LDFLAGS = -nostdlib -Wl,--build-id=none,-T,$(SRC_DIR)/flat.lds > +override LDFLAGS = -nostdlib -Wl,--build-id=none,-T,$(SRC_DIR)/flat.lds > -Wl,--no-warn-rwx-segments -Wl,--no-warn-execstack > > pvh.img: pvh.o pvh_main.o > > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
