On Wed, Dec 13, 2023 at 08:09:29PM +0530, Ani Sinha wrote: > > > > On 13-Dec-2023, at 8:03 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > > > > On Wed, Dec 13, 2023 at 04:24:24PM +0530, Ani Sinha wrote: > >> > >> > >>> On 13-Dec-2023, at 4:20 PM, Gerd Hoffmann <kra...@redhat.com> wrote: > >>> > >>> Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > >> > >> Please combine this patch with patch 5. No need to do this separately. > > > > > > Yes but since it's done - it's fine either way I think. No? > > Yes I did not realise it was a PR and not a review. I thought it was sent for > review. If it’s done it’s ok. > That being said, I would have preferred that the commit had a description and > not completely empty.
I agree, Gerd, going forward please include the diff of the disassemled AML. > > > >>> --- > >>> tests/qtest/bios-tables-test-allowed-diff.h | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h > >>> b/tests/qtest/bios-tables-test-allowed-diff.h > >>> index e569098abddc..dfb8523c8bf4 100644 > >>> --- a/tests/qtest/bios-tables-test-allowed-diff.h > >>> +++ b/tests/qtest/bios-tables-test-allowed-diff.h > >>> @@ -1,2 +1 @@ > >>> /* List of comma-separated changed AML files to ignore */ > >>> -"tests/data/acpi/virt/SSDT.memhp", > >>> -- > >>> 2.43.0 > >>> > >
