On 27.01.2012, at 00:17, Andreas Färber wrote: > From: Anthony Liguori <aligu...@us.ibm.com> > > Signed-off-by: Anthony Liguori <aligu...@us.ibm.com> > > Split macio into two PCIDevices with declarative device ID, > macio-oldworld and macio-newworld. Drop is_oldworld state in favor > of two separate init functions and deferred creation. > > Signed-off-by: Andreas Färber <afaer...@suse.de> > Cc: Alexander Graf <ag...@suse.de> > --- > Anthony, I've extended and tested your patch, please consider using this > version. > (In that case feel free to move your Signed-off-by down.) > > Alex, please ack. We could inline macio_init() and get rid of is_oldworld but > would have to move MacIOState into ppc_mac.h then.
I don't see anything obviously wrong with the patch, but this is the type of thing that you just have to shove through testing and if it works, it works :). Alex
