On Thu, Jan 04, 2007 at 12:52:56PM -0500, Jonathan Phenix wrote: >Bernhard Fischer wrote: >>Hi, >> >>The attached patch moves the x_keycode_to_pc_keycode LUT from sdl.c into >>an x_keycode.c. This struct is also used by the GGI backend (that is not >>yet merged ยน). >> >>Comments? >> >How it is done right now, each time x_keycode.c is included, you will >end up with an extra copy in the final executable. Perhaps that simply >keeping the LUT in sdl.c but removing the 'static' keyword from it and >creating a sdl.h file with the statement:
Yes, or create one public accessor func (_translate_keycode() or the like). I don't have SDL installed, so only have the LUT once, but you're of course right. What's the preferred method? public LUT or public accessor? _______________________________________________ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
