Am 26.05.2025 um 15:21 hat Fiona Ebner geschrieben: > The quorum_del_child() callback runs under the graph lock, so it is > not allowed to drain. It is only called as the .bdrv_del_child() > callback, which is only called in the bdrv_del_child() function, which > also runs under the graph lock. > > The bdrv_del_child() function is called by qmp_x_blockdev_change(). > A drained section was already introduced there by commit "block: move > drain out of quorum_add_child()". > > This finally finishes moving out the drain to places that are not > under the graph lock started in "block: move draining out of > bdrv_change_aio_context() and mark GRAPH_RDLOCK". > > Signed-off-by: Fiona Ebner <f.eb...@proxmox.com>
With the usual comments added: Reviewed-by: Kevin Wolf <kw...@redhat.com>
