Am 26.05.2025 um 15:21 hat Fiona Ebner geschrieben: > This is part of resolving the deadlock mentioned in commit "block: > move draining out of bdrv_change_aio_context() and mark GRAPH_RDLOCK". > > The function bdrv_attach_child() runs under the graph lock, so it is > not allowed to drain. It is called by: > 1. replication_start() > 2. quorum_add_child() > 3. bdrv_open_child_common() > 4. Throughout test-bdrv-graph-mod.c and test-bdrv-drain.c unit tests. > > In all callers, a drained section is introduced. > > The function quorum_add_child() runs under the graph lock, so it is > not actually allowed to drain. This will be addressed by the following > commit. > > Signed-off-by: Fiona Ebner <f.eb...@proxmox.com>
You won't be surprised that bdrv_attach_child() should have a comment stating the draining requirement, too. With this fixed: Reviewed-by: Kevin Wolf <kw...@redhat.com>
