Am 26.05.2025 um 15:21 hat Fiona Ebner geschrieben: > This is part of resolving the deadlock mentioned in commit "block: > move draining out of bdrv_change_aio_context() and mark GRAPH_RDLOCK". > > The quorum_add_child() callback runs under the graph lock, so it is > not allowed to drain. It is only called as the .bdrv_add_child() > callback, which is only called in the bdrv_add_child() function, which > also runs under the graph lock. > > The bdrv_add_child() function is called by qmp_x_blockdev_change(), > where a drained section is introduced. > > Signed-off-by: Fiona Ebner <f.eb...@proxmox.com>
Here we should have the documentation about the draining requirement on both BlockDriver.bdrv_add_child() and the bdrv_add_child() wrapper. With the added comments: Reviewed-by: Kevin Wolf <kw...@redhat.com>
