Am 26.05.2025 um 15:21 hat Fiona Ebner geschrieben: > This is part of resolving the deadlock mentioned in commit "block: > move draining out of bdrv_change_aio_context() and mark GRAPH_RDLOCK". > > The function bdrv_root_attach_child() runs under the graph lock, so it > is not allowed to drain. It is called by: > 1. blk_insert_bs(), where a drained section is introduced. > 2. block_job_add_bdrv(), which holds the graph lock itself. > > block_job_add_bdrv() is called by: > 1. mirror_start_job() > 2. stream_start() > 3. commit_start() > 4. backup_job_create() > 5. block_job_create() > 6. In the test_blockjob_common_drain_node() unit test > > In all callers, a drained section is introduced. > > Signed-off-by: Fiona Ebner <f.eb...@proxmox.com>
Same thing as in previous patches with comments. With that fixed: Reviewed-by: Kevin Wolf <kw...@redhat.com>
