Peter Xu <pet...@redhat.com> writes: > Src QEMU sets block_inactive=true very early before the invalidation takes > place. It means if something wrong happened during setting the flag but > before reaching qemu_savevm_state_complete_precopy_non_iterable() where it > did the invalidation work, it'll make block_inactive flag inconsistent. > > For example, think about when qemu_savevm_state_complete_precopy_iterable() > can fail: it will have block_inactive set to true even if all block drives > are active. > > Fix that by only update the flag after the invalidation is done. > > No Fixes for any commit, because it's not an issue if bdrv_activate_all() > is re-entrant upon all-active disks - false positive block_inactive can > bring nothing more than "trying to active the blocks but they're already > active". However let's still do it right to avoid the inconsistent flag > v.s. reality. > > Signed-off-by: Peter Xu <pet...@redhat.com>
Reviewed-by: Fabiano Rosas <faro...@suse.de>
