Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1258072?usp=email )
Change subject: Implement deletetalk option for older MediaWiki versions
......................................................................
Implement deletetalk option for older MediaWiki versions
- Make deletetalk delete the talk page for mw_version < 1.38wmf24
- Add tests for older MediaWiki behavior
Bug: T420176
Change-Id: I66dd198ea78c33dc8964214a3ff7c7ba187ba77f
---
M pywikibot/site/_apisite.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Xqt: Verified; Looks good to me, approved
diff --git a/pywikibot/site/_apisite.py b/pywikibot/site/_apisite.py
index b1f9072..51c04de 100644
--- a/pywikibot/site/_apisite.py
+++ b/pywikibot/site/_apisite.py
@@ -2693,9 +2693,12 @@
if deletetalk:
if self.mw_version < '1.38wmf24':
- pywikibot.warning(
- f'deletetalk is not available on {self.mw_version}'
- )
+ if not page.isTalkPage():
+ talk_page = page.toggleTalkPage()
+ talk_page.delete(reason=reason, prompt=False)
+ else:
+ raise ValueError('Cannot use "deletetalk" when deleting '
+ 'a talk page.')
else:
params['deletetalk'] = deletetalk
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1258072?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I66dd198ea78c33dc8964214a3ff7c7ba187ba77f
Gerrit-Change-Number: 1258072
Gerrit-PatchSet: 11
Gerrit-Owner: Kengkong <[email protected]>
Gerrit-Reviewer: JJMC89 <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
