Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1257301?usp=email )
Change subject: Tests: Fix TestProofreadPageValidSite.test_url_image
......................................................................
Tests: Fix TestProofreadPageValidSite.test_url_image
The API response seems not to be deterministic,
see also previous fixes.
Bug: T419943
Change-Id: I542fdf053597fd65541732845faec0604ef50a50
---
M tests/proofreadpage_tests.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Xqt: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py
index a4f6f45..333fdaf 100755
--- a/tests/proofreadpage_tests.py
+++ b/tests/proofreadpage_tests.py
@@ -256,9 +256,12 @@
valid_redlink = {
'title': 'Page:Pywikibot test page 3.jpg',
- 'url_image':
+ 'url_image': (
+ 'https://upload.wikimedia.org/wikisource/en/3/37/'
+ 'Pywikibot_test_page_3.jpg',
'https://upload.wikimedia.org/wikisource/en/thumb/3/37/'
'Pywikibot_test_page_3.jpg/60px-Pywikibot_test_page_3.jpg',
+ )
}
existing_invalid = {
@@ -406,7 +409,6 @@
"""Test fetching of url image of the scan of ProofreadPage."""
page = ProofreadPage(self.site, self.valid['title'])
self.assertEqual(page.url_image, self.valid['url_image'])
-
page = ProofreadPage(self.site, self.existing_unlinked['title'])
# test Exception in property.
with self.assertRaisesRegex(
@@ -416,7 +418,8 @@
page.url_image
page = ProofreadPage(self.site, self.valid_redlink['title'])
- self.assertEqual(page.url_image, self.valid_redlink['url_image'])
+ # seems the result is not deterministic
+ self.assertIn(page.url_image, self.valid_redlink['url_image'])
class TestPageQuality(TestCase):
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1257301?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I542fdf053597fd65541732845faec0604ef50a50
Gerrit-Change-Number: 1257301
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
