Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1251360?usp=email )
Change subject: Tests: Fix TestProofreadPageValidSite.test_url_image ...................................................................... Tests: Fix TestProofreadPageValidSite.test_url_image The API response was changed somehow recently. It always gives thumbs back even if fullsize is expected. See: - https://www.mediawiki.org/wiki/Extension:Proofread_Page/API:imageforpage - https://en.wikisource.org/wiki/Special:ApiSandbox#action=query&format=json&prop=imageforpage&titles=Page%3APywikibot%20test%20page%203.jpg&formatversion=2 Bug: T419943 Change-Id: I565cce9f7c65208d8d99467523a93dc952875147 --- M tests/proofreadpage_tests.py 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Xqt: Verified; Looks good to me, approved diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py index c7518e2..a4f6f45 100755 --- a/tests/proofreadpage_tests.py +++ b/tests/proofreadpage_tests.py @@ -256,8 +256,9 @@ valid_redlink = { 'title': 'Page:Pywikibot test page 3.jpg', - 'url_image': ('https://upload.wikimedia.org/wikisource/en/3/37/' - 'Pywikibot_test_page_3.jpg'), + 'url_image': + 'https://upload.wikimedia.org/wikisource/en/thumb/3/37/' + 'Pywikibot_test_page_3.jpg/60px-Pywikibot_test_page_3.jpg', } existing_invalid = { @@ -408,7 +409,10 @@ page = ProofreadPage(self.site, self.existing_unlinked['title']) # test Exception in property. - with self.assertRaises(ValueError): + with self.assertRaisesRegex( + ValueError, + 'imagesforpage is empty|No prp-page-image src found' + ): page.url_image page = ProofreadPage(self.site, self.valid_redlink['title']) -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1251360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I565cce9f7c65208d8d99467523a93dc952875147 Gerrit-Change-Number: 1251360 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <[email protected]> Gerrit-Reviewer: Xqt <[email protected]> Gerrit-Reviewer: jenkins-bot
_______________________________________________ Pywikibot-commits mailing list -- [email protected] To unsubscribe send an email to [email protected]
