jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1092834?usp=email )
Change subject: [IMPR] Show a warning if ignore_extension was set and the
extension is invalid.
......................................................................
[IMPR] Show a warning if ignore_extension was set and the extension is invalid.
Change-Id: I23a58ed419faee25109b243ecc30f2b570dbe8c4
---
M pywikibot/page/_filepage.py
1 file changed, 14 insertions(+), 9 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page/_filepage.py b/pywikibot/page/_filepage.py
index 703d178..3e3fd88 100644
--- a/pywikibot/page/_filepage.py
+++ b/pywikibot/page/_filepage.py
@@ -43,9 +43,15 @@
"""Initializer.
.. versionchanged:: 8.4
- check for valid extensions.
+ Check for valid extensions.
.. versionchanged:: 9.3
- *ignore_extension* parameter was added
+ Added the optional *ignore_extension* parameter.
+ .. versionchanged:: 9.6
+ Show a warning if *ignore_extension* was set and the
+ extension is invalid.
+ .. seealso::
+ :meth:`Site.file_extensions
+ <pywikibot.site._apisite.APISite.file_extensions>`
:param source: the source of the page
:type source: pywikibot.page.BaseLink (or subclass),
@@ -62,16 +68,15 @@
if self.namespace() != 6:
raise ValueError(f"'{self.title()}' is not in the file namespace!")
- if ignore_extension:
- return
-
title = self.title(with_ns=False, with_section=False)
_, sep, extension = title.rpartition('.')
if not sep or extension.lower() not in self.site.file_extensions:
- raise ValueError(
- f'{title!r} does not have a valid extension '
- f'({", ".join(self.site.file_extensions)}).'
- )
+ msg = (f'{title!r} does not have a valid extension\n'
+ f'({", ".join(self.site.file_extensions)}).')
+ if not ignore_extension:
+ raise ValueError(msg)
+
+ pywikibot.warning(msg)
def _load_file_revisions(self, imageinfo) -> None:
"""Save a file revision of FilePage (a FileInfo object) in local cache.
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1092834?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I23a58ed419faee25109b243ecc30f2b570dbe8c4
Gerrit-Change-Number: 1092834
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
