Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1097954?usp=email )
Change subject: tests: destroy tkinter dialog window after creation
......................................................................
tests: destroy tkinter dialog window after creation
Bug: T380732
Change-Id: Ie60c8560b3e3cc4d45da90c69f90ebf51c17ea68
---
M .github/workflows/pywikibot-ci.yml
M tests/gui_tests.py
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Xqt: Verified; Looks good to me, approved
diff --git a/.github/workflows/pywikibot-ci.yml
b/.github/workflows/pywikibot-ci.yml
index 4b1ce54..1c50929 100644
--- a/.github/workflows/pywikibot-ci.yml
+++ b/.github/workflows/pywikibot-ci.yml
@@ -140,7 +140,7 @@
if [ ${{matrix.site || 0}} != 'wikisource:zh' ]; then
coverage run -m unittest discover -vv -p \"*_tests.py\";
else
- pytest -vv --cov=.;
+ pytest -v --cov=.;
fi
- name: Show coverage statistics
diff --git a/tests/gui_tests.py b/tests/gui_tests.py
index dd1e7bc..91cb975 100755
--- a/tests/gui_tests.py
+++ b/tests/gui_tests.py
@@ -91,9 +91,11 @@
raise unittest.SkipTest(e)
try:
- tkinter.Tk()
+ dialog = tkinter.Tk()
except RuntimeError as e:
raise unittest.SkipTest(f'Skipping due to T380732 - {e}')
+ else:
+ dialog.destroy()
from pywikibot.userinterfaces.gui import EditBoxWindow, Tkdialog
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/1097954?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ie60c8560b3e3cc4d45da90c69f90ebf51c17ea68
Gerrit-Change-Number: 1097954
Gerrit-PatchSet: 2
Gerrit-Owner: Xqt <[email protected]>
Gerrit-Reviewer: Xqt <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
Pywikibot-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
