Tal Einat <talei...@gmail.com> added the comment:

Because of the method of implementation, a dialog can be created without 
specifying a parent. There was at least one instance of this in IDLE before my 
patch. This is a bug, since the behavior of the dialog in this instance is 
obviously incorrect (the user can switch focus back to the parent while the 
dialog is still open).

I found that making the EditorWindow the default parent was the best way to 
both fix the bug, make the code more readable, and avoid replicating this bug 
in the future. Feel free to write up a different patch or change mine if you 
feel so strongly about the default parent.

The process of discussing this patch has taken far, far too long. I can't stand 
such discussions spanning months (and years!). Please just accept this patch or 
close it. I'm fed up with this.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue2053>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to