Yury Selivanov added the comment: > I believe that I addressed all the comments in the previous review (although > its always possible I missed something), and have a new patch with the > improvements and fixes.
Thanks Eric! I've left a few more comments in the review. Almost there! > I also noticed that in asyncio, loop.shutdown_asyncgens() is a > coroutinemethod and fixed the markup to reflect that as I previously labeled > it a method. The example I added here is as suggested, but it differs from > the example in PEP525 in that shutdown_asyncgens() is run in a finally > clause, which makes sense to me. Right, I'll fix the PEP. Thanks! ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28091> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
