Eric Appelt added the comment: I believe that I addressed all the comments in the previous review (although its always possible I missed something), and have a new patch with the improvements and fixes.
I also noticed that in asyncio, loop.shutdown_asyncgens() is a coroutinemethod and fixed the markup to reflect that as I previously labeled it a method. The example I added here is as suggested, but it differs from the example in PEP525 in that shutdown_asyncgens() is run in a finally clause, which makes sense to me. When applying the comments to sys.set_asyncgen_hooks() I verified that the keywords are optional but it is apparently not keyword only. I couldn't find many good examples of referencing source, so you may want to closely check how I linked to the shutdown_asyncgens() implementation. ---------- Added file: http://bugs.python.org/file45868/pep525_pep530_docs_v1.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28091> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
