Antoine Pitrou added the comment:

Thanks. Could you also add a test for the islice_reduce additions? Or is it 
already tested?
I suspect there's a reference leak there: after calling PyObject_GetIter, you 
should always Py_DECREF(empty_list).
Also, with the "O" code, Py_BuildValue will take a new reference to empty_it, 
so you should use the "N" code instead.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue21321>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to