Zbyszek Szmek <zbys...@in.waw.pl> added the comment: Here's updated version: termsize.diff.1
> Ok, a couple of general comments: > - there is no point having a separate module for a single function; I > think > the os module (and posixmodule.c for the C side) is a > reasonable place where to put this Done. (But posixmodule.c is so enourmous... I feel bad making it even longer.) > - C code should be indented with 4 spaces increments and no tabs (see > PEP 7) > - constants in C code should be uppercase > - C code should be C89-compliant and therefore we don't use named > struct initializers (such as ".m_size = 0") All done, I hope. This version was tested on linux/amd64 and win32 (XP). ---------- Added file: http://bugs.python.org/file23983/termsize.diff.1 _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue13609> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
