Antoine Pitrou <pit...@free.fr> added the comment: Ok, a couple of general comments: - there is no point having a separate module for a single function; I think the os module (and posixmodule.c for the C side) is a reasonable place where to put this - C code should be indented with 4 spaces increments and no tabs (see PEP 7) - constants in C code should be uppercase - C code should be C89-compliant and therefore we don't use named struct initializers (such as ".m_size = 0")
---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue13609> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
