sbt <shibt...@gmail.com> added the comment:

> Ok, a couple of further (minor) issues:
> - I don't think AssertionError is the right exception type. TypeError 
> should be used when a type mismatches (e.g. "not an unicode object");
> - you don't need to check for d_type being NULL, since other methods don't;
> - if type_qualname == NULL, the original error should be retained.

Fixed.  (I suspect, though, that caching the value of __qualname__ is an 
unnecessary optimisation.)

----------
Added file: http://bugs.python.org/file23927/descr_qualname.patch

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13577>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to