Antoine Pitrou <pit...@free.fr> added the comment:

The patch should add some tests for the added functionality (I'm not sure 
where, but perhaps test_descr is a good location).
Also, just a nitpick, you can use _PyObject_GetAttrId and the _Py_IDENTIFIER 
macro instead of interning the "__qualname__" string yourself.

Note that extension (non-builtin) types will need to have their __qualname__ 
fixed before their methods' __qualname__ is usable:

>>> collections.deque.__qualname__
'deque'

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13577>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to