Charles-François Natali <neolo...@free.fr> added the comment:
mkstemp() creates the file with mode 0600, which can be surprising.
I'm note sure about the best way to handle this:
1) change the file mode after creating it with fchmod(), using the source file
mode. But we must also take into account the umask, so we'd have to do:
mask = umask(0);
umask(mask);
[...]
fd = mkstemp(cpathname_tmp)
fchmod(fd, mode & ~mask);
The double call to umask() is necessary because we can't just retrieve the umask
2) don't use mkstemp(), and use something like:
sprintf(cpathname_tmp, "%s.%x", cpathname, 0xffff & getpid());
d = open(cpathname_tmp, O_WRONLY|O_CREAT|O_EXCL);
to mimic what's done in Lib/importlib/_bootstrap.py (pseudo-temp file).
3) Fall back to the original ".tmp" suffix (with the risk of stale tmp file).
Thoughts?
----------
status: closed -> open
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13303>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
