Benjamin Peterson <benja...@python.org> added the comment: 2011/5/24 Charles-François Natali <rep...@bugs.python.org>: > > Charles-François Natali <neolo...@free.fr> added the comment: > >> You change caused test_socketserver to hang. I attempted a fix, but I'm not >> sure if it's completely correct. > > I'm a morron. > I don't know how I could miss this: closing the server socket is perfectly > fine in TCP, since a new one is returned by accept(). But in UDP, it's > definitely wrong, since it's used by the handler. > I don't know however how I missed this, since I remember having run > test_socketserver... > > The best fix is simply to revert the patch.
Done. > I'm really sorry about this... Don't worry. It's a bit of a rite of passage for new developers to break the buildbots. :) ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue5715> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
