Andi, I'll send in a new patch for you to look at. It patches setup.py, jcc/__init__.py, and jcc/windows.py. I've tried to honor all your constraints.
Bill Andi Vajda <va...@apache.org> wrote: > > On Mar 19, 2010, at 19:57, Bill Janssen <jans...@parc.com> wrote: > > > Andi Vajda <va...@apache.org> wrote: > > > >>> Andi Vajda <va...@apache.org> wrote: > >>> > >>>> I integrated your changes in trunk rev 925041. > >>> > >>> I took a look at this, and I don't think it will work. You can't > >>> import > >>> jcc.windows before writing jcc.config, for one thing. I'll put it > >>> back > >>> in setup.py again? > >> > >> This is imported during jcc build time. The jcc package is right > >> there, available. Why wouldn't it work ? > > > > Because if you say "import jcc.windows" at that point, it will try to > > load the "jcc" package that's right there in that directory. And the > > __init__.py in that package says, "from jcc.config import SHARED". > > And > > jcc/config.py doesn't exist till later in the setup.py file. > > Ah ok, I missed that. The import of config.py can be surrounded by > try/ > catch since SHARED is not needed during jcc build time. I'll add that > and simulate the execution path to find other such holes. > > Andi.. > > > > > >> What does config.py have to do with this at all ? > >> > >> All this is used for is setting a better default for win32/mingw32 > >> for > >> JDK['win32'] and JDK['mingw32']. > >> > >> Have you actually tried it ? (maybe I'm missing something). > > > > Yes, I tried it. Didn't work. > > > >> Having it back in setup.py is a non-starter since it pushes all the > >> other stuff people are supposed to edit manually two screens down and > >> they'll miss it. > > > > Of course, on windows they don't have to edit anything (now). OK, > > I'll > > push that code down further; maybe just creating a dummy empty > > config.py > > in the SVN would get around it. Hmmm, it would at least have to > > define > > > > SHARED=False > > > > I guess. > > > >>>> It would be easier to do this if you sent a patch, so I hope I > >>>> didn't > >>>> forget anything. Please check this on your syste. > >>> > >>> Using "svn diff" is good? > >> > >> Yes, that's perfect. > >> > >> Andi..
