On Fri, 19 Mar 2010, Bill Janssen wrote:
Andi Vajda <va...@apache.org> wrote:
I integrated your changes in trunk rev 925041.
I took a look at this, and I don't think it will work. You can't import
jcc.windows before writing jcc.config, for one thing. I'll put it back
in setup.py again?
This is imported during jcc build time. The jcc package is right there,
available. Why wouldn't it work ?
What does config.py have to do with this at all ?
All this is used for is setting a better default for win32/mingw32 for
JDK['win32'] and JDK['mingw32'].
Have you actually tried it ? (maybe I'm missing something).
Having it back in setup.py is a non-starter since it pushes all the other
stuff people are supposed to edit manually two screens down and they'll
miss it.
It would be easier to do this if you sent a patch, so I hope I didn't
forget anything. Please check this on your syste.
Using "svn diff" is good?
Yes, that's perfect.
Andi..
