>>Feel free to choose a better name ;-) We can the mark this API as >>unstable/experimental, and modify >>the parameters/types. IMHO most existing parameters does not really makes >>sense with external migration. >>I guess it is still possible to factor out most common code to avoid code >>duplication. >> >>What do you think?
ok no problem. I'll rework my patches next week (I'm on holiday this week). Also, I out of idea for the qm command name. 'qm migrate_external" ? ----- Mail original ----- De: "dietmar" <[email protected]> À: "pve-devel" <[email protected]>, "aderumier" <[email protected]> Envoyé: Mardi 13 Novembre 2018 11:22:23 Objet: Re: [pve-devel] [PATCH qemu-server 1/7] api2 : migrate_vm : add migration_type "external" I would like to move forward with that, but changing an existing API makes that difficult. I would suggest to add a second API entry point instead: __PACKAGE__->register_method({ name => 'external_migrate_vm', path => '{vmid}/external_migrate', method => 'POST', ... Feel free to choose a better name ;-) We can the mark this API as unstable/experimental, and modify the parameters/types. IMHO most existing parameters does not really makes sense with external migration. I guess it is still possible to factor out most common code to avoid code duplication. What do you think? _______________________________________________ pve-devel mailing list [email protected] https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
