Hi all,

When creating a live snapshot this function is called:
sub __snapshot_save_vmstate {
    my ($class, $vmid, $conf, $snapname, $storecfg) = @_;

    my $snap = $conf->{snapshots}->{$snapname};

    my $target;

    # search shared storage first
    PVE::QemuServer::foreach_writable_storage($conf, sub {
        my ($sid) = @_;
        my $scfg = PVE::Storage::storage_config($storecfg, $sid);
        return if !$scfg->{shared};

$target = $sid if !$target || $scfg->{path}; # prefer file based storage
    });

    if (!$target) {
        # now search local storage
        PVE::QemuServer::foreach_writable_storage($conf, sub {
            my ($sid) = @_;
            my $scfg = PVE::Storage::storage_config($storecfg, $sid);
            return if $scfg->{shared};

$target = $sid if !$target || $scfg->{path}; # prefer file based storage;
        });
    }

    $target = 'local' if !$target;
[....]

It doesn't seem obvious to me why we prefer shared storage over local storage? Above assumes that we are able to store two snapshots for each VM/CT we are making a live snapshot for on the share storage.

--
Hilsen/Regards
Michael Rasmussen

Get my public GnuPG keys:
michael <at> rasmussen <dot> cc
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xD3C9A00E
mir <at> datanom <dot> net
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE501F51C
mir <at> miras <dot> org
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xE3E80917
--------------------------------------------------------------

----

This mail was virus scanned and spam checked before delivery.
This mail is also DKIM signed. See header dkim-signature.

_______________________________________________
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to