> Fiona Ebner <f.eb...@proxmox.com> hat am 24.06.2025 12:05 CEST geschrieben:
>
>
> Am 24.06.25 um 11:48 schrieb Fabian Grünbichler:
> >> Fiona Ebner <f.eb...@proxmox.com> hat am 23.06.2025 17:44 CEST geschrieben:
> >> diff --git a/src/test/run_config2command_tests.pl
> >> b/src/test/run_config2command_tests.pl
> >> index 9f4ecabf..52fedd7b 100755
> >> --- a/src/test/run_config2command_tests.pl
> >> +++ b/src/test/run_config2command_tests.pl
> >> @@ -248,7 +248,7 @@ $qemu_server_module->mock(
> >> get_host_arch => sub() {
> >> return $current_test->{host_arch} // 'x86_64';
> >> },
> >> - get_initiator_name => sub {
> >> + get_iscsi_initiator_name => sub {
> >> return 'iqn.1993-08.org.debian:01:aabbccddeeff';
> >> },
> >
> > hmm, this works "by accident"
> >
> >> cleanup_pci_devices => {
> >> diff --git a/src/test/run_qemu_img_convert_tests.pl
> >> b/src/test/run_qemu_img_convert_tests.pl
> >> index 55144994..86eb53be 100755
> >> --- a/src/test/run_qemu_img_convert_tests.pl
> >> +++ b/src/test/run_qemu_img_convert_tests.pl
> >> @@ -504,7 +504,7 @@ $qemu_server_module->mock(
> >> run_command => sub {
> >> $command = shift;
> >> },
> >> - get_initiator_name => sub {
> >> + get_iscsi_initiator_name => sub {
> >
> > same here - should we move it to mock Helpers already in this patch?
>
> No, not by accident. You do need to mock it where it's imported!
ugh, TIL (again I guess)! thanks for the clarification!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
