Am 15.11.24 um 16:17 schrieb Dominik Csapak: > This series enables importing ova/ovf from directory based storages, > inclusive upload/download via the webui (ova only). > > It also improves the ovf importer by parsing the ostype, nics, bootorder > (and firmware from vmware exported files). > > I opted to move the OVF.pm to pve-storage, since there is no > real other place where we could put it. I put it in a new module > 'GuestImport' > > We now extract the images into either a given target storage or in the > import storage in the 'images' dir so accidentally left over images > are discoverable by the ui/cli. > > This version is half rebased on fabians hardening series: > https://lore.proxmox.com/pve-devel/20241104104221.228730-1-f.gruenbich...@proxmox.com/ > > I sent the qemu-server patch from fabian again but omitted some > problematic checks. I add them later with a check > against the import vtype again (last patch in qemu-server) > > changes from v5: > * removed leftover hunks in makefile > * moved ova checks to correct patch > * split up error messages for unexpected format > * remove unnecessary untaint > * reword error message > * reintroduce symlink check in ova/ovf check > * added sanity check for ovas after uploading/downloading > * added new patch for checking import vtypes > * fixed issue with files with absolute path
Looks like it's quite in good shape, I left a few comments on a few patches, but mostly for some style/naming stuff. Would be great if Fiona could take another look and possibly also Fabian, some testing from others would naturally also be nice, maybe you can organise that. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
