On 21.04.21 16:38, Stefan Reiter wrote: > On 21/04/2021 16:29, Thomas Lamprecht wrote: >> On 21.04.21 13:15, Stefan Reiter wrote: >>> ...such as proxmox-file-restore. >>> >> >> For public interface I'd rather see a separate sub, like: >> >> run_file_restore_cmd >> >> and ideally not even that would be required from an external POV, i.e., why >> want >> to avoid to expose a general run_something command here, a clear interface, >> like >> you add then for most (all?) things like file_restore_extract, >> file_restore_list, >> ..., is in general better (when thinking anti-spaghetti-no-check code). >> > > This is not part of a public interface though? Both functions that now > support the 'binary' argument are declared private...
hmm, ok, then I misread something... _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel