On 29.06.2012 15:55, jcbollinger wrote:
On Friday, June 29, 2012 1:51:52 AM UTC-5, Brian Gupta wrote:
According to the style guide, "Classes and defined resource types
must not be defined within other classes."
However looking at
https://github.com/puppetlabs/puppetlabs-nginx/blob/master/manifests/init.pp
<https://github.com/puppetlabs/puppetlabs-nginx/blob/master/manifests/init.pp>
shows that there are a number of other classes defined in class nginx.
You are misreading that manifest: it does not define any classes in
class nginx. Rather it /declares/ several classes using parameterized
class syntax. "Defining" a class is this:
class foo {
# declare resources
}
"Declaring" a class is this:
class { 'foo':
# parameters, if any
}
or
include "foo"
or
require "foo"
The manifest you referred to does only the latter. I'd argue that it
could and should use "include" for those instead of parametrized class
syntax, but it does not conflict with the style guide point you referenced.
Note, however, that elsewhere the style guide (version 1.1.2) says
"*Classes should generally not declare other classes*," which is a bunch
of bologna. A Puppetlabs employee told me recently that he would have
that removed, but evidently it hasn't happened yet.
Indeed! Even more so as using the word "declare" for "include" is a load
of utter bollocks. "Declare" in the common programming language sense
means "indicating the existence of a thing that is defined elsewhere."
Like "declaring an external variable" or "(pre-)declaring a method", and
never indicates actions taken.
Best Regards, David
--
You received this message because you are subscribed to the Google Groups "Puppet
Users" group.
To post to this group, send email to puppet-users@googlegroups.com.
To unsubscribe from this group, send email to
puppet-users+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en.
