On Jan 5, 7:45 am, Walter Heck <walterh...@gmail.com> wrote:
> I was afraid this was going to be the only solution. I guess we could
> really do with more sane handling of arrays in puppet. This is a
> workaround to make a workaround work..
Characterizing anything here as a workaround suggests that you are
fighting against the tool. That is bound to leave you dissatisfied,
and likely to lead you to commit the same kinds of errors again, which
will make you even more dissatisfied.
Definitions establish user-defined resource types. The resources of
any given type must all have unique names. Puppet provides a short-
cut mechanism, using arrays, for declaring multiple resources with the
same properties but different names. This is all perfectly sensible.
You are causing yourself problems by construing definitions to provide
a looping construct. They do not. Puppet DSL does not have such a
construct, thus you should discipline yourself to avoid thinking in
such terms when you are writing Puppet manifests. Instead, be sure to
write definitions that have some kind of inherent meaning and
observable manifestation on the target node, and then, among other
things, it will flow naturally that each instance gets a distinct
title.
If you cannot or do not wish to adapt to Puppet DSL's declarative
nature, then you can always write Ruby manifests instead.
Here is how I might write it (a variant of Felix's first suggestion),
stripped to the essentials:
define reprepro::repo::conf_override() {
include 'reprepro::params'
$distro_and_name = split($name, ':')
$distribution = $distro_and_name[0]
$override_name = $distro_and_name[1]
file { "${reprepro::params::repo_base_dir}/${distribution}/conf/
override.${override_name}":
ensure => "present"
}
}
define reprepro::repo($distribution, $codenames) {
reprepro::repo::conf_override { regsubst($codenames, /^/, "$
{distribution}:"): }
}
Some notes on that:
1) it is not necessary to copy the $codenames array prior to passing
it to regsubst. Nothing changes a Puppet variable's value once it is
set, including Puppet functions.
2) Because definition 'reprepro::repo::conf_override' uses a variable
from class 'reprepro::params', it should 'include' that class, as
shown, even if it seems safe to assume that that class will have
already been included.
3) It would be possible, and perhaps slightly safer, to set the
distribution name as a parameter to Reprepro::repo::conf_override, and
then to use that to extract the "override_name". I chose instead to
avoid duplication of information.
4) It might also be possible to interpolate the elements of array
$distro_and_name directly into the file name instead of first
assigning each to a scalar variable, but assigning the elements to
their own variables serves better for self-documentation.
John
--
You received this message because you are subscribed to the Google Groups
"Puppet Users" group.
To post to this group, send email to puppet-users@googlegroups.com.
To unsubscribe from this group, send email to
puppet-users+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/puppet-users?hl=en.
