On Sep 16, 2008, at 12:16 PM, Digant C Kasundra wrote: > > Hello everyone, > > My team and I have been mulling over the module standards that were > proposed (http://www.reductivelabs.com/trac/puppet/wiki/ModuleStandards > ) > > Members of our team like to break large classes up into tiny pieces, > which isn't covered in this doc. For instance, if a class declares > 10 files and 12 packages and 5 services, there is a preference to > break these into foo::files, foo::packages, and foo:services and > then have foo include these things. My problem with this is that I > like to preserve a clear representation that :: denotes that the > thing following is a subclass of the thing proceeding (so > ssh::server means this is a subclass of ssh, relating specifically > to ssh). > > So my proposal is if there is need or want to break up large > classes, the fragment class (i.e. foo::files) be named specifically > in a way that makes it clear it is not a complete and functional > class but only a fragment. Such a naming convention might call for > something like foo::_files or foo::inc::files. I would like to open > this topic up to discussion to the greater community (you guys) and > see what you think.
Are your classes really getting that long? And does it really make sense to split them based on resource type, rather than some other organizational criteria? The cfengine community was often hampered by a tendency to organize by action type rather than functional role, so I consider it a kind of code smell in Puppet. -- Aizu's Second Law: What changes the world is communication, not information. --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---