Hi Lars, We don't have people actively working on open-source protobuf right now and that's why you haven't seen these patches been applied. We have planed a major release in Q2/Q3 though. At that time we'll go through all the open issues. It's better to submit this patch to the issue tracker because it's very easy to miss email threads and unlike the issue tracker we won't go through these emails again.
Thanks very much for helping improving protobufs! Regards, Feng On Sun, Jan 19, 2014 at 5:52 AM, Lars Olsson <[email protected]> wrote: > Hello, > > I need Protobuf to work on Solaris, so attached is a patch to fix Solaris > 10 and and Solaris 11 support. > > After I had already made the patch, I discovered in the issue tracker > (issues 561 and 565) that someone else has tried to fix this before, but it > doesn't appear their patch has been applied to the trunk, even though > they're quite old now? > So, I'm posting my patch, because it fixes the above problems and more. > I hope someone can merge it to svn; it applies cleanly to the trunk of > today's date. > Not sure if this is the proper way to go about it, but there are already > multiple issues regarding Solaris support so I don't want to pollute the > tracker further. > If I need to do something more to get someone to look at this, please let > me know. > > I have tested PB with my patch applied on the following configurations: > > Solaris 10: > * SPARC: > * GCC 3.4.3: > * 32-bit: PASS > * 64-bit: PASS > * Solaris Studio 12.3: > * 32-bit: PASS > * 64-bit: PASS > * x86: > * GCC 3.4.3: > * 32-bit: PASS > * 64-bit: PASS > * Solaris Studio 12.3: > * 32-bit: PASS > * 64-bit: PASS > > Solaris 11.1: > * x86: > * GCC 4.5.2: > * 32-bit: PASS > * 64-bit: PASS > * Solaris Studio 12.3: > * 32-bit: PASS > * 64-bit: PASS > > Ubuntu 13.10: > (This was a sanity-check to ensure I didn't inadvertently break something.) > * x86: > * GCC 4.8.1 > * 64-bit: PASS > > Test procedure: > > $ ./configure > or (for 32-bit): $ ./configure --disable-64bit-solaris > $ make > $ make check > > PASS = built and all tests passed. > > I don't have access to a SPARC Solaris 11 machine so I have not been able > to test that configuration, although I believe it should work. > > Regards, > Lars > > -- > You received this message because you are subscribed to the Google Groups > "Protocol Buffers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/protobuf. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "Protocol Buffers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/protobuf. For more options, visit https://groups.google.com/groups/opt_out.
