jmckenzie-dev commented on code in PR #347:
URL: https://github.com/apache/cassandra-sidecar/pull/347#discussion_r3244123209
##########
server/src/test/java/org/apache/cassandra/sidecar/cdc/CdcPublisherTests.java:
##########
@@ -111,204 +112,22 @@ void setUp()
cdcPublisher = new CdcPublisher(
vertx,
- sidecarConfiguration,
executorPools,
clusterConfigProvider,
schemaSupplier,
- sidecarInstancesProvider,
- clientConfig,
instanceMetadataFetcher,
cdcConfig,
databaseAccessor,
cdcStats,
virtualTables,
sidecarCdcStats,
- avroSerializer,
- rangeManager
- );
- }
-
-
- @Test
- void testSecretsProviderReturnsNullWhenSslDisabled()
Review Comment:
You sure? Looking at the diff I see:
```
void testSecretsProviderWithSslEnabledNoKeystoreNoTruststore()
void testSecretsProviderWithKeystoreOnly()
void testSecretsProviderWithTruststoreOnly()
void testSecretsProviderWithBothKeystoreAndTruststore()
void testSecretsProviderUsesCorrectSslConfigKeys()
``
Don't see ReturnsNullWhenSslDisabled.
##########
server/src/test/java/org/apache/cassandra/sidecar/cdc/CdcPublisherTests.java:
##########
@@ -111,204 +112,22 @@ void setUp()
cdcPublisher = new CdcPublisher(
vertx,
- sidecarConfiguration,
executorPools,
clusterConfigProvider,
schemaSupplier,
- sidecarInstancesProvider,
- clientConfig,
instanceMetadataFetcher,
cdcConfig,
databaseAccessor,
cdcStats,
virtualTables,
sidecarCdcStats,
- avroSerializer,
- rangeManager
- );
- }
-
-
- @Test
- void testSecretsProviderReturnsNullWhenSslDisabled()
Review Comment:
You sure? Looking at the diff I see:
```
void testSecretsProviderWithSslEnabledNoKeystoreNoTruststore()
void testSecretsProviderWithKeystoreOnly()
void testSecretsProviderWithTruststoreOnly()
void testSecretsProviderWithBothKeystoreAndTruststore()
void testSecretsProviderUsesCorrectSslConfigKeys()
```
Don't see ReturnsNullWhenSslDisabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
