jyothsnakonisa commented on code in PR #347:
URL: https://github.com/apache/cassandra-sidecar/pull/347#discussion_r3241795736
##########
server/src/main/java/org/apache/cassandra/sidecar/cdc/CachingSchemaStore.java:
##########
@@ -132,8 +146,15 @@ private void configureSidecarServerEventListeners()
return v;
});
}
- loadPublisher();
- publishSchemas();
+ try
+ {
+ loadPublisher();
+ publishSchemas();
+ }
+ catch (Exception e)
+ {
+ LOGGER.error("Failed to publish schemas to Kafka during
initialization, CDC will still start", e);
Review Comment:
ON_CDC_CACHE_WARMED_UP event never gets called until there is a schema
change if we don't proceed and CDC never starts.
I agree with u that if we proceed when schema publishing fails, we will miss
the update in schemastore and there might be issues during deserialization.
WDYT of adding a retry when schema publishing fails? we can call
ON_CDC_CACHE_WARMED_UP when it succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
