belliottsmith commented on code in PR #271: URL: https://github.com/apache/cassandra-accord/pull/271#discussion_r3211249843
########## accord-core/src/main/java/accord/local/CatchupHard.java: ########## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package accord.local; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Objects; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import accord.api.DataStore.FetchRanges; +import accord.coordinate.FetchDurableBefore; +import accord.local.PreLoadContext.Empty; +import accord.primitives.Range; +import accord.primitives.Ranges; +import accord.primitives.SaveStatus; +import accord.primitives.Timestamp; +import accord.primitives.TxnId; +import accord.utils.Reduce; +import accord.utils.ReducingRangeMap; +import accord.utils.async.AsyncChain; +import accord.utils.async.AsyncChains; +import accord.utils.async.AsyncResult; +import accord.utils.async.AsyncResults; +import accord.utils.async.AsyncResults.SettableResult; + +import static accord.local.RedundantStatus.Property.LOG_UNAVAILABLE; +import static accord.local.RedundantStatus.SomeStatus.LOG_UNAVAILABLE_ONLY; +import static accord.primitives.Routables.Slice.Minimal; + +/** + * Catch up this data store to the point of any quorum + */ +public class CatchupHard Review Comment: Good question. I think for now it's fine, it will just not retry, which is less important for CatchupHard. But I will be considering this logic again soon, and will consider what might be good to add here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
