ifesdjeen commented on code in PR #271:
URL: https://github.com/apache/cassandra-accord/pull/271#discussion_r3208409306
##########
accord-core/src/main/java/accord/local/Commands.java:
##########
@@ -836,8 +840,8 @@ protected static WaitingOn
initialiseWaitingOn(SafeCommandStore safeStore, TxnId
protected static Update updateWaitingOn(SafeCommandStore safeStore,
ICommand waiting, Timestamp executeAt, WaitingOn.Update initialise)
{
RedundantBefore redundantBefore = safeStore.redundantBefore();
- TxnId minWaitingOnTxnId = initialise.minWaitingOnTxnId();
- if (minWaitingOnTxnId != null &&
redundantBefore.hasLocallyRedundantDependencies(initialise.minWaitingOnTxnId(),
executeAt, waiting.participants().waitsOn()))
+ TxnId minWaitingOnTxnId = initialise.minWaitingOnTxn();
+ if (minWaitingOnTxnId != null &&
redundantBefore.hasLocallyRedundantDependencies(initialise.minWaitingOnTxn(),
executeAt, waiting.participants().waitsOn()))
Review Comment:
probably more of a nit, but still, on L844, `initialise.minWaitingOnTxn()`
can just be `minWaitingOnTxnId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
