jyothsnakonisa commented on code in PR #341:
URL: https://github.com/apache/cassandra-sidecar/pull/341#discussion_r3184821633
##########
server/src/main/java/org/apache/cassandra/sidecar/modules/ConfigurationModule.java:
##########
@@ -68,14 +69,30 @@
public class ConfigurationModule extends AbstractModule
{
private static final Logger LOGGER =
LoggerFactory.getLogger(ConfigurationModule.class);
+ @Nullable
protected final Path confPath;
+ @Nullable
+ private final SidecarConfiguration config;
/**
* Constructs the Guice main module to run Cassandra Sidecar
*/
public ConfigurationModule()
{
confPath = null;
+ config = null;
+ }
Review Comment:
Can we get rid of this so that config/config path are not left unset by
mistake. Removing this will give compiletime error if config/path is not set
correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
