yifan-c commented on code in PR #341:
URL: https://github.com/apache/cassandra-sidecar/pull/341#discussion_r3165736318
##########
server/src/main/java/org/apache/cassandra/sidecar/modules/UtilitiesModule.java:
##########
@@ -88,6 +92,14 @@ SidecarVersionProvider sidecarVersionProvider()
return new SidecarVersionProvider("/sidecar.version");
}
+ @Provides
+ @Singleton
+ SidecarInstancesProvider sidecarInstancesProvider(InstancesMetadata
instancesMetadata,
+ ServiceConfiguration
serviceConfiguration)
+ {
+ return new DynamicSidecarInstancesProvider(instancesMetadata,
serviceConfiguration);
+ }
Review Comment:
It was declared in the `CdcModule`, but should really be moved there as it
is used by other components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
