rustyrazorblade commented on PR #4734: URL: https://github.com/apache/cassandra/pull/4734#issuecomment-4355488544
> @jmckenzie-dev @rustyrazorblade @netudima anything else you would like to see in the first iteration of this? cc @dcapwell Thanks for checking. I took a brief scan and I think @dcapwell has covered what I would have asked to address. It's a solid first pass and I expect to treat this as a living document more than we normally would, so I'm not concerned with having it be absolutely perfect. I think the biggest item that can be left to follow ups would be to improve the clarity around the code structure and the relationship between different core classes and their responsibilities. That can just as easily be a follow up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
