jcshepherd commented on code in PR #4773:
URL: https://github.com/apache/cassandra/pull/4773#discussion_r3150606832
##########
src/java/org/apache/cassandra/auth/AuthConfig.java:
##########
@@ -60,48 +87,52 @@ public static void applyAuth()
Config conf = DatabaseDescriptor.getRawConfig();
-
- /* Authentication, authorization and role management backend,
implementing IAuthenticator, I*Authorizer & IRoleManager */
-
- IAuthenticator authenticator = authInstantiate(conf.authenticator,
AllowAllAuthenticator.class);
+ // Load and normalize authenticator configuration
+ AuthenticatorConfig authConfig = loadAuthenticatorConfig(conf);
// the configuration options regarding credentials caching are only
guaranteed to
// work with PasswordAuthenticator, so log a message if some other
authenticator
// is in use and non-default values are detected
- if (!(authenticator instanceof PasswordAuthenticator || authenticator
instanceof MutualTlsAuthenticator)
+ if (!(authConfig.defaultAuthenticator instanceof PasswordAuthenticator
|| authConfig.defaultAuthenticator instanceof MutualTlsAuthenticator)
Review Comment:
I think this check should probably be made if any configured authenticator
is a password or MTLS authenticator, not just the default. .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
