jcshepherd commented on code in PR #4773:
URL: https://github.com/apache/cassandra/pull/4773#discussion_r3150625048
##########
src/java/org/apache/cassandra/auth/AuthConfig.java:
##########
@@ -158,4 +186,245 @@ private static <T> T authInstantiate(ParameterizedClass
authCls, Class<T> defaul
throw new ConfigurationException("Failed to instantiate " +
defaultCls.getName(), e);
}
}
+
+ /**
+ * Validates the require_authentication setting when authenticator
negotiation is configured. If
+ * require_authentication is true, all authenticators must require
authentication. If require_authentication is
+ * false and non-authenticating authenticators are present, logs a warning
and continues.
+ */
+ private static void validateRequireAuthentication(AuthenticatorConfig
authConfig)
+ {
+ // Check all negotiable authenticators (includes default)
+ for (IAuthenticator auth : authConfig.negotiableAuthenticators)
+ {
+ if (!auth.requireAuthentication())
Review Comment:
s/auth/authenticator/ for clarity please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
