lukasz-antoniak commented on code in PR #336:
URL: https://github.com/apache/cassandra-sidecar/pull/336#discussion_r3091607815
##########
server/src/main/java/org/apache/cassandra/sidecar/db/RestoreJobDatabaseAccessor.java:
##########
@@ -217,17 +226,12 @@ public List<RestoreJob> findAllByCreationDate(LocalDate
date)
{
sidecarSchema.ensureInitialized();
- BoundStatement statement = tableSchema.findAllByCreatedAt().bind(date);
+ BoundStatement statement = tableSchema.findAllByCreatedAt().bind(date)
+
.setConsistencyLevel(tableSchema.getConsistencyLevel());
ResultSet resultSet = execute(statement);
List<RestoreJob> result = new ArrayList<>();
for (Row row : resultSet)
{
- if (resultSet.getAvailableWithoutFetching() == 100 &&
!resultSet.isFullyFetched())
Review Comment:
Pre-fetching was removed.
[Documentation](https://github.com/apache/cassandra-java-driver/blob/4.x/upgrade_guide/README.md):
> ResultSet behaves much like its 3.x counterpart, except that background
pre-fetching (fetchMoreResults) was deliberately removed, in order to keep this
interface simple and intuitive. If you were using synchronous iterations with
background pre-fetching, you should now switch to fully asynchronous iterations
(see below).
Since, we are fetching here restores that happened on given day, I was not
sure if refactoring to fully async make s sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
